No overflow? That's an InitD function. The value was being divided and multiplied when it should not have been, and the ffc index wasn't properly offset. Both my fault, and I sent him a text file with the patch, that he committed while my laptop was in surgery.Originally Posted by Gleeok
I'm glad someone new is interested in working on ZC. That is good news! :)
Yeah, I've noticed he's been working on various things recently and that you were helping him along, although I haven't looked at any of the commits; I guess I'll do that right now.
...Well that didn't take long.
The last commit was a two-line fix:
Correct me if I'm wrong, but that looks like overflow to me.Code:- //m->initd[(ri->d[0]/10000)][(ri->d[1]/10000)] = (value/10000); + m->initd[(ri->d[0]/10000) - 1][(ri->d[1]/10000)] = value;...or did I just get (un)lucky with my timing?
Both InitD and MiscD are always a raw values, and I forgot that here, when I wrote 300 ZScript commands all at once. All refinfo registers are also always raw.
Off-topic, but my plans this week are to finish uop bitmaps, fix script drawing stuff--cset2 related-- and to ffix some other critical bugs. I'm going to start on npc script stuff soon, as well. I need to get bitmap->Blit(dest,args) and some basic draw commands in for bitmaps, so that I can test if bitmap->Create(h,w) works as I intend.
I finally got that in there in the most straightforward manner possible.
Anyway, he's doing a good job, seems dedicated, and his outpit is constructive.
